Replace instanceof Array with Array.isArray (#2812)

Author: t3chguy

src/crypto/verification/SAS.ts

@@ -217,7 +217,7 @@ const MAC_SET = new Set(MAC_LIST);
 const SAS_SET = new Set(SAS_LIST);
 
 function intersection<T>(anArray: T[], aSet: Set<T>): T[] {
-    return anArray instanceof Array ? anArray.filter(x => aSet.has(x)) : [];
+    return Array.isArray(anArray) ? anArray.filter(x => aSet.has(x)) : [];
 }
 
 export enum SasEvent {

src/sliding-sync-sdk.ts

@@ -82,7 +82,7 @@ class ExtensionE2EE implements Extension {
             const unusedFallbackKeys = data["device_unused_fallback_key_types"] ||
                 data["org.matrix.msc2732.device_unused_fallback_key_types"];
             this.crypto.setNeedsNewFallback(
-                unusedFallbackKeys instanceof Array &&
+                Array.isArray(unusedFallbackKeys) &&
                 !unusedFallbackKeys.includes("signed_curve25519"),
             );
         }

src/sync.ts

@@ -1482,7 +1482,7 @@ export class SyncApi {
             const unusedFallbackKeys = data["device_unused_fallback_key_types"] ||
                 data["org.matrix.msc2732.device_unused_fallback_key_types"];
             this.opts.crypto.setNeedsNewFallback(
-                unusedFallbackKeys instanceof Array &&
+                Array.isArray(unusedFallbackKeys) &&
                 !unusedFallbackKeys.includes("signed_curve25519"),
             );
         }

src/utils.ts

@@ -232,7 +232,7 @@ export function deepCompare(x: any, y: any): boolean {
     }
 
     // the object algorithm works for Array, but it's sub-optimal.
-    if (x instanceof Array) {
+    if (Array.isArray(x)) {
         if (x.length !== y.length) {
             return false;
         }