Integration tests should wait until the room is ready #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
approved these changes
Jul 8, 2022
MatrixSDKTests/MXCryptoTests.m
Outdated
Comment on lines
3441
to
3442
| - (void)restartSession:(MXSession *)session | ||
| waitingForRoomId:(NSString *)roomId |
There was a problem hiding this comment.
The indentation is a little out of on this and the 2 calls to it.
|
|
||
| // Even when sync completed, there are actually still a few async updates that happen (i.e. the notification | ||
| // fires too early), so have to add some small arbitrary delay. | ||
| dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 1 * NSEC_PER_SEC), dispatch_get_main_queue(), ^{ |
There was a problem hiding this comment.
Kind of annoying to have to stall for a whole second, but can see why it is needed 🙁
There was a problem hiding this comment.
Yea it is indeed. I would fix the notification, but then have no test to proove that I did not break something else, so this should be passing first before any changes to production code.
MatrixSDKTests/MXCryptoTests.m
Outdated
Comment on lines
3452
to
3453
| observer = [[NSNotificationCenter defaultCenter] addObserverForName:kMXSessionNewRoomNotification | ||
| object:nil |
|
Oh, but missing a changelog, I forgot to add that to the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the flaky integration tests are failing because they manually start a session and try to get a room immediately. The problem with that approach is not only that the room may not be created at that point, but even if it is, not all state may be properly updated in the room summary.
The (partial) solution to this is to start sessions and then listen to global notifications that announce room creation or sync completeion. It is not 100% reliable, and requires a bit of manual delay, but it seems to be more reliable than the current setup.
Additionally I decided to enable the entire suite of
MXCryptoTestsand disable in code those that do not pass. This makes it more obvious when reading the test code and automatically adds any new tests to the test plan.