Skip to content

Add a way to set custom room version impls #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Jun 6, 2025

We have this lovely room version abstraction, but... no one can actually use it without getting it into this map. Let's fix that.

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 16 lines in your changes missing coverage. Please review.

Project coverage is 59.42%. Comparing base (c70b213) to head (38b41c3).

Files with missing lines Patch % Lines
eventauth.go 44.44% 15 Missing ⚠️
eventcontent.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   59.43%   59.42%   -0.01%     
==========================================
  Files          51       51              
  Lines        7257     7271      +14     
==========================================
+ Hits         4313     4321       +8     
- Misses       2544     2550       +6     
  Partials      400      400              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Else you can't make custom versions..
Copy link
Contributor

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a potential test addition, this looks perfectly reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants