Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement registering with an email support #1298

Open
kegsay opened this issue Aug 24, 2020 · 5 comments
Open

Implement registering with an email support #1298

kegsay opened this issue Aug 24, 2020 · 5 comments
Labels
are-we-synapse-yet This issue or PR involves Sytests in AWSY C-Client-API F-Registration T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@kegsay
Copy link
Member

kegsay commented Aug 24, 2020

Spec: https://matrix.org/docs/spec/client_server/r0.6.1#email-based-identity-homeserver
Sytests:

    × Can register using an email address
@kegsay kegsay added good first issue Want to help with Dendrite? These are the issues to start with! are-we-synapse-yet This issue or PR involves Sytests in AWSY labels Aug 24, 2020
@rohitgeddam
Copy link

I want to work on it!

@kegsay
Copy link
Member Author

kegsay commented Sep 4, 2020

Great, thanks! Check out #dendrite-dev:matrix.org if you want some help :)

@PiotrKozimor
Copy link
Contributor

The Derived struct was about to be deleted - #889, #1230. There is Registration field in it which contains allowable authentication flows. To my understanding it is not used yet. How do we want to populate it?

@PiotrKozimor
Copy link
Contributor

I want to take another approach on it: dendrite will send confirmation email on it's own. This would also enable another requests to be handled internally:

  • POST /_matrix/client/r0/account/password/email/requestToken
  • POST /_matrix/client/r0/account/3pid/email/requestToken

It would also enable logging with email as long as ID servers would no longer be used.

Regarding configuration - I want to pass allowed flows and parameters explicitly in it, e.g.:

client_api:
  registration:
    flows:
      - stages:
        - m.login.recaptcha
        - m.login.email.identity
    parameters: 
      m.login.recaptcha:
        public_key: foobar

It would be validated on dendrite startup and any error would be reported as fatal. If SMTP configuration will be passed to dendrite, user could pass m.login.email.identity stage to flow.

Any thoughts on this?

@PiotrKozimor
Copy link
Contributor

@kegsay the first part - extension of UserAPI - is implemented here: #1970

@kegsay kegsay added C-Client-API T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. F-Registration and removed good first issue Want to help with Dendrite? These are the issues to start with! labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
are-we-synapse-yet This issue or PR involves Sytests in AWSY C-Client-API F-Registration T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants