Test knock rooms appear in the public room directory #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
force-pushed
the
anoa/knock_public_room_directory_test
branch
from
3d3222d
to
5759777
Compare
anoadragon453
force-pushed
the
anoa/knock_public_room_directory_test
branch
from
5759777
to
50ee113
Compare
kegsay
reviewed
Feb 10, 2021
kegsay
approved these changes
Feb 10, 2021
anoadragon453
force-pushed
the
anoa/knock_public_room_directory_test
branch
from
3e044e8
to
c35a2c7
Compare
kegsay
approved these changes
Feb 10, 2021
anoadragon453
added a commit
to matrix-org/synapse-dinsic
that referenced
this pull request
Feb 10, 2021
… can be knocked on (#82) This PR implements the ["Changes regarding the Public Rooms Directory"](https://github.com/Sorunome/matrix-doc/blob/soru/knock/proposals/2403-knock.md#changes-regarding-the-public-rooms-directory) section of knocking MSC2403. Specifically, it: * Allows rooms with `join_rule` "knock" to be returned by the query behind the public rooms directory * Adds the field `join_rule` to each room entry returned by a public rooms directory query, so clients can know whether to attempt a join or knock on a room This PR is a clone of [the mainline PR](matrix-org/synapse#9359). Complement tests for this change: matrix-org/complement#72.
anoadragon453
added a commit
to matrix-org/synapse
that referenced
this pull request
Jun 9, 2021
This PR implements the ["Changes regarding the Public Rooms Directory"](https://github.com/Sorunome/matrix-doc/blob/soru/knock/proposals/2403-knock.md#changes-regarding-the-public-rooms-directory) section of knocking MSC2403. Specifically, it: * Allows rooms with `join_rule` "knock" to be returned by the query behind the public rooms directory * Adds the field `join_rule` to each room entry returned by a public rooms directory query, so clients can know whether to attempt a join or knock on a room Based on #6739. Complement tests for this change: matrix-org/complement#72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests the "Changes regarding the Public Rooms Directory" section of knocking MSC2403.
Essentially boiling down to:
join_ruleentry in the room result to know whether to knock or not to knock. It really is the question.