Skip to content

Add test for failover of federated joins #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

squahtx
Copy link
Contributor

@squahtx squahtx commented Feb 15, 2023

When performing a federated join, the homeserver accepts a list of
servers to try joining via. When the first remote server in the list is
not in the room, the federated join ought to try the rest of the list
instead of failing immediately.

Signed-off-by: Sean Quah seanq@matrix.org


Synapse currently fails the test. matrix-org/synapse#15074 fixes it.

When performing a federated join, the homeserver accepts a list of
servers to try joining via. When the first remote server in the list is
not in the room, the federated join ought to try the rest of the list
instead of failing immediately.

Signed-off-by: Sean Quah <seanq@matrix.org>
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@squahtx squahtx merged commit a4039f3 into main Feb 15, 2023
@squahtx squahtx deleted the squah/add_federated_join_failover_test branch February 15, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants