Merge pull request #116 from dstansby/begone-circular-ref

Remove circular ref in base widget

Author: ruaridhg

src/napari_matplotlib/base.py

@@ -48,7 +48,6 @@ def __init__(self, napari_viewer: napari.viewer.Viewer):
 
         self.viewer = napari_viewer
         self.canvas = FigureCanvas()
-        self.canvas.widget = self
 
         self.canvas.figure.patch.set_facecolor("none")
         self.canvas.figure.set_layout_engine("constrained")

src/napari_matplotlib/tests/test_histogram.py

@@ -1,3 +1,5 @@
+from copy import deepcopy
+
 import pytest
 
 from napari_matplotlib import HistogramWidget
@@ -9,4 +11,6 @@ def test_example_q_widget(make_napari_viewer, astronaut_data):
     viewer = make_napari_viewer()
     viewer.add_image(astronaut_data[0], **astronaut_data[1])
     fig = HistogramWidget(viewer).figure
-    return fig
+    # Need to return a copy, as original figure is too eagerley garbage
+    # collected by the widget
+    return deepcopy(fig)

src/napari_matplotlib/tests/test_slice.py

@@ -1,3 +1,5 @@
+from copy import deepcopy
+
 import pytest
 
 from napari_matplotlib import SliceWidget
@@ -8,4 +10,6 @@ def test_slice(make_napari_viewer, brain_data):
     viewer = make_napari_viewer()
     viewer.add_image(brain_data[0], **brain_data[1])
     fig = SliceWidget(viewer).figure
-    return fig
+    # Need to return a copy, as original figure is too eagerley garbage
+    # collected by the widget
+    return deepcopy(fig)