Bugfix/dapcleanup #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you merge this as soon as its ready? I would like to install basemap to build the mpl docs. |
|
Done. I think I did it correctly. |
|
Looks like I don't know what I am doing yet. I think I merged it up to my fork's master... |
|
Not quite. You need to push to matplotlib/basemap. You pushed to your own fork. Once you push to matplotlib/basemap, this pull request will automatically be closed. |
|
in your repo: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A completely clean/fresh source build of basemap will fail due to the lack of a vestigial lib/dap directory. This pull should remove any remaining references to lib/dap from the MANIFEST.in and setup.py.