stuff

Author: Denis Ermolin

contracts/staking/stakeManager/StakeManager.sol

@@ -567,11 +567,17 @@ contract StakeManager is
         address currentSigner = validators[validatorId].signer;
         // update signer event
         logger.logSignerChange(validatorId, currentSigner, signer, signerPubkey);
+        
+        if (validators[validatorId].deactivationEpoch == 0) { 
+            // didn't unstake, safe to remove the signer from the list
+            _removeSigner(currentSigner);
+        }
+        
+        _insertSigner(signer);
 
         signerToValidator[currentSigner] = INCORRECT_VALIDATOR_ID;
         signerToValidator[signer] = validatorId;
         validators[validatorId].signer = signer;
-        _updateSigner(currentSigner, signer);
 
         // reset update time to current time
         latestSignerUpdateEpoch[validatorId] = _currentEpoch;
@@ -1202,11 +1208,6 @@ contract StakeManager is
         }
     }
 
-    function _updateSigner(address prevSigner, address newSigner) internal {
-        _removeSigner(prevSigner);
-        _insertSigner(newSigner);
-    }
-
     function _removeSigner(address signerToDelete) internal {
         uint256 totalSigners = signers.length;
         address swapSigner = signers[totalSigners - 1];

package-lock.json

@@ -6,6 +6,7 @@ import {
 } from '../../../helpers/utils.js'
 import { expectEvent, expectRevert, BN } from '@openzeppelin/test-helpers'
 import { wallets, walletAmounts, freshDeploy, approveAndStake } from '../deployment'
+import { assert } from 'chai'
 
 module.exports = function(accounts) {
   let owner = accounts[0]
@@ -317,6 +318,48 @@ module.exports = function(accounts) {
   })
 
   describe('unstake', function() {
+    describe('when Alice unstakes and update the signer', function() {
+      const AliceWallet = wallets[1]
+      const BobWallet = wallets[3]
+      const AliceNewWallet = wallets[2]
+
+      before(freshDeploy)
+      before(doStake(AliceWallet))
+      before(doStake(BobWallet))
+      before('Change signer', async function() {
+        const signerUpdateLimit = await this.stakeManager.signerUpdateLimit()
+        await this.stakeManager.advanceEpoch(signerUpdateLimit)
+
+        this.validatorId = await this.stakeManager.getValidatorId(AliceWallet.getAddressString())
+        
+      })
+
+      it('Alice should unstake', async function() {
+        this.receipt = await this.stakeManager.unstake(this.validatorId, {
+          from: AliceWallet.getAddressString()
+        })
+      })
+
+      it('Signers list should have only Bob\'s signer', async function() {
+        assert((await this.stakeManager.signers(0)) == BobWallet.getChecksumAddressString(), 'no Bob signer!')
+        await expectRevert.unspecified(this.stakeManager.signers(1))
+      })
+
+      it('Alice should update signer', async function() {
+        await this.stakeManager.updateSigner(this.validatorId, AliceNewWallet.getPublicKeyString(), {
+          from: AliceWallet.getAddressString()
+        })
+      })
+
+      it('Signers list should have new Alice\'s signer and Bob\'s signer', async function() {
+        const signers = [await this.stakeManager.signers(0), await this.stakeManager.signers(1)]
+
+
+        assert(signers.findIndex(x => x == AliceNewWallet.getChecksumAddressString()) !== -1, 'no Alice signer!')
+        assert(signers.findIndex(x => x == BobWallet.getChecksumAddressString()) !== -1, 'no Bob signer!')
+      })
+    })
+
     describe('when user unstakes right after stake', async function() {
       const user = wallets[2].getChecksumAddressString()
       const amounts = walletAmounts[wallets[2].getAddressString()]