Fix most type hinting issues in library/lcd #622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
library/lcd
was full of type hinting issues, which made the code light up like a (season-appropriate) Christmas tree in VSCode with Pylance 🎄The same issues can be reported on the command-line with Pyright.
I've fixed (almost) all typing issues. I tried to keep the logic bug-for-bug compatible; except for Colors where I had to change a few things, and I took the opportunity to improve the parsing and now colors can be specified in more ways.
Sorry for the big MR, but there were a lot of intricate changes and it would have been hard to split it.
The only remaining typing issues in
library/lcd
are now the RGB-serialization methods inlcd_comm_{b,c,d}
, which I didn't try to fix as I may try porting them to numpy later anyway.