Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Q] Revert library name for Arduino Library Manager compatibility? #25

Closed
nomakewan opened this issue Oct 7, 2024 · 7 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@nomakewan
Copy link

Since ESPAsyncWebServer restored its old name in order to get picked up by the Arduino Library Manager, would it be possible to have the same done here?

Reference: https://github.com/mathieucarbou/ESPAsyncWebServer/releases/tag/v3.3.12

Alternatively, perhaps it would be worth going through the official rename request process for the Arduino Library Manager?

https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name

At the moment AsyncTCP it's stuck at 3.1.4 due to the library name change.

Thank you!

@nomakewan nomakewan added the question Further information is requested label Oct 7, 2024
@mathieucarbou
Copy link
Owner

AsyncTCP has always been named AsyncTCP: https://github.com/me-no-dev/AsyncTCP/blob/master/library.properties#L1C1-L1C14

@mathieucarbou
Copy link
Owner

Ah! I know what happened! Yes I need to add back the space... Will do it now.

@mathieucarbou mathieucarbou self-assigned this Oct 7, 2024
@mathieucarbou mathieucarbou added bug Something isn't working and removed question Further information is requested labels Oct 7, 2024
@mathieucarbou
Copy link
Owner

fixed: https://github.com/mathieucarbou/AsyncTCP/releases/tag/v3.2.7

@nomakewan
Copy link
Author

Woah! Thank you so much for the speedy fix!

@mathieucarbou
Copy link
Owner

Woah! Thank you so much for the speedy fix!

But you'll have to wait until tomorrow to see in it Arduino IDE I think ;-)

@nomakewan
Copy link
Author

Ah, I think there might be a little error in the library.properties. Shouldn't cludes=AsyncTCP.h be includes=AsyncTCP.h?

@mathieucarbou
Copy link
Owner

Ah, I think there might be a little error in the library.properties. Shouldn't cludes=AsyncTCP.h be includes=AsyncTCP.h?

crap!!!! copy paste issue! fixing it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants