Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text overflow should be represented by ellipsis in schema selector #984

Closed
pavish opened this issue Jan 19, 2022 · 3 comments · Fixed by #1166
Closed

Text overflow should be represented by ellipsis in schema selector #984

pavish opened this issue Jan 19, 2022 · 3 comments · Fixed by #1166
Assignees
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory

Comments

@pavish
Copy link
Member

pavish commented Jan 19, 2022

Description

In the schema selector, if the name of the schema is large, text overflows and visually breaks abruptly.

Screenshot 2022-01-19 at 10 11 08 PM

Expected behavior

Overflown text should be truncated and ellipsis should be displayed, as represented in the following image:

Screenshot 2022-01-19 at 10 16 15 PM

To Reproduce

  1. Create a schema with a large name
  2. Open schema selector in the navigation menu
@pavish pavish added type: bug Something isn't working good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this work: frontend Related to frontend code in the mathesar_ui directory labels Jan 19, 2022
@pavish pavish added this to the [05.3] 2022-01 improvements milestone Jan 19, 2022
@kgodey kgodey added the ready Ready for implementation label Jan 19, 2022
@seancolsen
Copy link
Contributor

Suggestion to implementer: do this in CSS via text-overflow: ellipsis;

@sahilsaini1107
Copy link
Contributor

@seancolsen please assign this to me.

@silentninja silentninja added status: started and removed ready Ready for implementation labels Mar 12, 2022
@silentninja
Copy link
Contributor

Thanks, @sahilsaini110 I have assigned the issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants