Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accommodate frontend code in repo #59

Closed
pavish opened this issue Apr 26, 2021 · 1 comment · Fixed by #95
Closed

Accommodate frontend code in repo #59

pavish opened this issue Apr 26, 2021 · 1 comment · Fixed by #95
Assignees
@pavish
Labels
affects: architecture Improvements or additions to architecture affects: dx Related to developer experience type: maintenance Refactoring and technical debt payoff
Milestone
[01] Viewing Tables

Comments

@pavish
Copy link
Member

pavish commented Apr 26, 2021

Related to #53

A separate directory for frontend code and workflow actions needs to be created.

We would need:

  • A separate service in docker-compose to build the client files for development - logistics need to be figured out.
  • For production builds, we will have to build client and place it in static web server folder before creating a bundle/container.
  • Separate workflow for lint, test and build steps for client.
@pavish pavish added affects: dx Related to developer experience affects: architecture Improvements or additions to architecture type: maintenance Refactoring and technical debt payoff labels Apr 26, 2021
@pavish
Copy link
Member Author

pavish commented Apr 26, 2021 •
edited
Loading

Blocked by #55

Edit: Decided to move forward with Svelte + Django templates approach, refer #55

This was referenced Apr 28, 2021
Merged
Merged
Merged
@kgodey kgodey closed this as completed in #95 May 3, 2021
@kgodey kgodey added this to the 01. Viewing Tables milestone Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavish pavish

Labels
affects: architecture Improvements or additions to architecture affects: dx Related to developer experience type: maintenance Refactoring and technical debt payoff
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
[01] Viewing Tables
Development

Successfully merging a pull request may close this issue.

Readme update for frontend development mathesar-foundation/mathesar
2 participants
@kgodey @pavish