Sorting bug

[aditmehta9]

Description

The sorting direction displayed in the sorting selection dropdown is incorrect, even though the sent request uses correct direction.

Expected behavior

Rows should be sorted in ascending order.

To Reproduce

First add 7 rows only in ID column then add another column- 'xyz' data type- date and time with null and no duplicates. Then sort the column using xyz and add another column for sorting that is id and now clear the XYZ from sorting or even delete the XYZ column the whole xyz

See below video or description.

When a direction is selected for New Col at first, the sort selected is desc but after it is applied it gets displayed as asc, but the results are correctly sorted in descending direction. The same desc order direction is also chosen as direction for any new sorting column that is added even though it is incorrectly displayed as asc.

Environment

• OS: (macOS,)
• Browser: (Firefox)

Additional context

Untitled.mp4

[muhsinkamil]

@silentninja Could you please assign this to me, I can take a look at it. Thanks

[silentninja]

Thanks, @muhsinkamil. I have assigned the issue to you

[muhsinkamil]

@silentninja It seems not to reproduce anymore after recent pull.
Could you please confirm with latest pull.

Screen.Recording.2022-03-29.at.12.51.07.PM.mov

[aditmehta9]

You are right this is working now.

[silentninja]

@muhsinkamil @aditmehta9 I am not able to reproduce the issue, maybe it was fixed by a recent merge. I am closing this as this is fixed. @pavish @seancolsen Can you point out the PR responsible for the fix, so that it is easier to track incase the issue occurs again.

[seancolsen]

I'm also not able to reproduce this bug in the current master branch.

@silentninja

Can you point out the PR responsible for the fix, so that it is easier to track incase the issue occurs again.

Good idea.

In the video, at 0:44 we have the sort direction selected as desc. Then at 0:45 after applying the sort direction, it displays as asc. That's the first indication of this bug. I'm able to reproduce that in 7a98cfd. Then in 77ad8ca (after #1240 was merged) I'm not able to reproduce it. The bug seems to have something to do with the SimpleSelect component, which no longer exists. I didn't spend the time to fully diagnose the problem though since I'm fairly confident it won't crop up again.

[silentninja]

I was also suspecting #1240 to be the PR responsible for the fix. Thanks @seancolsen