Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data type of ID #1245

Closed
aditmehta9 opened this issue Mar 27, 2022 · 3 comments
Closed

Data type of ID #1245

aditmehta9 opened this issue Mar 27, 2022 · 3 comments
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory

Comments

@aditmehta9
Copy link

Problem

Right now we can select only integer for the datatype of ID. But if a user clicks on ID dropdown -> Number-> Number Type. In Number Types, multiple options are shown i.e Float, decimal, integer. But can't select the other 2 number type. Either this option should not be shown or the user should be able to define this data type.

Proposed solution

Either this option should not be shown or the user should be able to define this data type.

Additional context

Screen-Recording-2022-03-27-at-1

@silentninja
Copy link
Contributor

silentninja commented Mar 28, 2022

We don't support changing the type of columns with dynamic defaults. In this case, id column has a autoincrement default, so the request gets rejected by the backend. The frontend should not allow such an operation to happen or show an error proper response. @pavish @seancolsen @kgodey Can anyone confirm the expected behaviour for this error.

@silentninja silentninja added work: frontend Related to frontend code in the mathesar_ui directory status: draft and removed status: triage labels Mar 28, 2022
@kgodey
Copy link
Contributor

kgodey commented Mar 29, 2022

We have a design issue for handling primary keys. We'll handle the problems listed in this issue there, I've linked to this issue in the issue description for #439. I'm going to close this issue since there's no work to be done here yet.

@kgodey kgodey closed this as completed Mar 29, 2022
Repository owner moved this from Draft to Done in [NO LONGER USED] Mathesar work tracker Mar 29, 2022
@kgodey
Copy link
Contributor

kgodey commented Mar 29, 2022

I wanted to add: Thanks for reporting, @aditmehta9! Some of our features are still unfinished since we're still working towards our first release. Please continue to report any issues you see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

No branches or pull requests

3 participants