Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank row cells were added before user click add new row #1234

Closed
yans80 opened this issue Mar 26, 2022 · 2 comments
Closed

Blank row cells were added before user click add new row #1234

yans80 opened this issue Mar 26, 2022 · 2 comments
Assignees
Labels
type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory

Comments

@yans80
Copy link

yans80 commented Mar 26, 2022

Description

Blank cells were pre-filled next to add new record button before user click on them. It doesn't match the pattern for adding new columns, and a bit confusing as blank cells should appear after user click add new icon.

Expected behavior

Blank row cells will be added after user click add new row.

To Reproduce

mathesar_record_add_before

Environment

  • OS: (eg. macOS 10.14.6; Fedora 32)
  • Browser: (eg. Safari; Firefox)
  • Browser Version: (eg. 13; 73)
  • Other info:
@yans80
Copy link
Author

yans80 commented Mar 26, 2022

pull request that fix this issue: #1235

@kgodey kgodey self-assigned this Mar 29, 2022
@kgodey kgodey added this to the [06.1] 2022-03 improvements milestone Mar 29, 2022
@kgodey kgodey added work: frontend Related to frontend code in the mathesar_ui directory status: draft and removed status: triage labels Mar 29, 2022
@kgodey
Copy link
Contributor

kgodey commented Mar 29, 2022

@tsun812 This is an intentional design choice. We'd like users to be able to add a new record easily by adding data directly in the blank row.

It doesn't match the pattern for adding new columns

In a database, adding new records and adding new columns are very different operations. Adding a new column alters the structure of the data (it is a DDL operation) so it should be harder to do than adding new data (which is a DML operation).

I'm going to close this issue.

@kgodey kgodey closed this as completed Mar 29, 2022
Repository owner moved this from Draft to Done in [NO LONGER USED] Mathesar work tracker Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants