-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove url prefixing on frontend #1054
Comments
Hey, is anyone assigned to it? |
@sanjeevbhusal Not yet, do you want to work on it? |
Hello @kgodey, can I work on this issue? And just a side question, do we want this prefix URL to be configurable? |
Sure, go ahead @nimishbongale. I'll defer to @pavish on whether it should be configurable. |
No, we do not need it to be configurable at the moment. |
A bit more information on this issue: Whenever we make a request from the frontend (In places where we call methods like As mentioned in the issue description above, this is no longer desired since we now deal with multiple namespaces and possibly the need to use multiple versions of the same namespace. We need to specify the full url everywhere requests are made.
will change to:
|
I think I have a clearer understanding now, will make the necessary changes! Thanks @pavish! |
Description
Currently, the frontend appends a url prefix
/api/v0
in the api util. This was implemented earlier for two reasons:However, with the changes done for #1041, both these reasons are now void:
We need to remove the common method
appendUrlPrefix
within/mathesar_ui/src/utils/api.ts
and explicitly mention the prefix in each place where a request is made.The text was updated successfully, but these errors were encountered: