Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub development workflow not mentioned in contribution guidelines #46

Closed
aksaridh opened this issue Jun 10, 2022 · 5 comments
Closed

GitHub development workflow not mentioned in contribution guidelines #46

aksaridh opened this issue Jun 10, 2022 · 5 comments
Labels
stale May be out of date status: ready Ready for implementation type: enhancement New feature or request work: documentation Improvements or additions to documentation
Milestone
Backlog

Comments

@aksaridh
Copy link

The contributing guidelines do not mention which GitHub development workflow to follow when starting to write code. This may create confusion for contributors who have previously contributed in other projects (different projects may follow different workflows).

Possible workflows include:

  1. Create new branch in main repo. -> Make code changes in this branch -> PR
  2. Create personal fork of main repo. -> Create new branch in the personal fork -> Make code changes in this branch -> PR

This information should be included to avoid confusion among new contributors.
@aksaridh
Copy link
Author

It is possible that this information will be included in the "[NEW] Local development environment setup page" to be created as part of #41 (see linked discussion). This issue must be closed or kept open depending on that.

@kgodey kgodey self-assigned this Jun 10, 2022
@kgodey kgodey added work: documentation Improvements or additions to documentation type: enhancement New feature or request status: ready Ready for implementation labels Jun 10, 2022
@kgodey kgodey added this to the High Priority milestone Jun 10, 2022
@kgodey
Copy link
Contributor

kgodey commented Jun 10, 2022

Thanks for reporting this @aksaridh. For core and community team members, the workflow is (1) (from your options above). For everyone else, the workflow is (2).

@kgodey kgodey removed their assignment Sep 7, 2022
@kgodey kgodey modified the milestones: Cycle 5: First Release, 02. First Release Oct 5, 2022
@kgodey kgodey modified the milestones: 02. First Release, 03. Post-Release Improvements Nov 24, 2022
@kgodey kgodey modified the milestones: 02. Post-Release Improvements, Post-Release Improvements, Backlog Jan 5, 2023
@github-actions
Copy link

This issue has not been updated in 90 days and is being marked as stale.

@github-actions github-actions bot added the stale May be out of date label Jul 24, 2023
@rajatvijay rajatvijay removed the stale May be out of date label Jul 25, 2023
@github-actions GitHub Actions
Copy link

This issue has not been updated in 90 days and is being marked as stale.

@github-actions github-actions bot added the stale May be out of date label Feb 10, 2024
@kgodey
Copy link
Contributor

kgodey commented Feb 12, 2024

Closing this, too old and no one has brought this up in the intervening time.

@kgodey kgodey closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale May be out of date status: ready Ready for implementation type: enhancement New feature or request work: documentation Improvements or additions to documentation
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Status: Done
Milestone
Backlog
Development

No branches or pull requests
3 participants
@kgodey @rajatvijay @aksaridh