Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement i18n basic example #613

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AbnerSilvaBarbosa
Copy link

@AbnerSilvaBarbosa AbnerSilvaBarbosa commented Nov 29, 2023

Implement i18n basic example, it's just for see how this work and how is the architecture

at this moment I just create i18n for EN and PT-BR, but if necessary for now I can create more, and I just put i18n in the button (save, share and clear), because I don't see other place to do that, but if you have more thing I can do, if you have any one question I'm here 😄

" Sorry for my bad English "

Copy link

vercel bot commented Nov 29, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @mateusfg7 on Vercel.

@mateusfg7 first needs to authorize it.

@AbnerSilvaBarbosa AbnerSilvaBarbosa mentioned this pull request Nov 29, 2023
Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
noisekun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 11:25pm

@AbnerSilvaBarbosa
Copy link
Author

Some screenshot about how this is working in deploy

EN

screenshot_test_en

PT-BR

screenshot_test_pt-br

@mateusfg7
Copy link
Owner

Thanks for the PR @AbnerSilvaBarbosa!

I included some texts in the attributes of some HTML tags to
improve accessibility, like title=''. I think this needs to be translated too, and some modal texts, like Pomodoro Config.

@mateusfg7 mateusfg7 marked this pull request as draft November 30, 2023 11:42
@mateusfg7 mateusfg7 added feat New feature or request ux/ui Interface and style changes seo Changes related with Search Engine Optimization a11y Changes related to accessibility and removed seo Changes related with Search Engine Optimization labels Nov 30, 2023
@mateusfg7 mateusfg7 changed the title feat: implemented i18n basic example, it's just for see how this work… feat: implemented i18n basic example Nov 30, 2023
@mateusfg7 mateusfg7 changed the title feat: implemented i18n basic example feat: implement i18n basic example Nov 30, 2023
@AbnerSilvaBarbosa AbnerSilvaBarbosa marked this pull request as ready for review November 30, 2023 13:25
@AbnerSilvaBarbosa
Copy link
Author

You want I translate, too, the title of themes ? Like :

image

@mateusfg7
Copy link
Owner

You want I translate, too, the title of themes ? Like :

image

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Changes related to accessibility feat New feature or request ux/ui Interface and style changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants