Add selection by array #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this! Looks good too me - just want to get @Domino987 approval on this before merging. |
Domino987
requested changes
Nov 26, 2021
|
Ah yes, sorry about missing that. I thought the types came in from DefinitelyTyped. As someone who uses mostly TypeScript I appreciate you ensuring they are kept up-to-date. Updated. |
Domino987
approved these changes
Nov 26, 2021
This was referenced May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #416
Description
Support passing an array to the
fieldattribute of a column. Allowing the selection of keys with full-stops.Details for why this would be valuable can be found in the related issue.
Related PRs
None that I can find.
Impacted Areas in Application
columnspropAdditional Notes
Thanks for considering this PR and your hard work on this project.