-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## develop #45 +/- ##
========================================
Coverage 79.01% 79.01%
========================================
Files 8 8
Lines 224 224
========================================
Hits 177 177
Misses 47 47 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #45 +/- ##
========================================
Coverage 79.01% 79.01%
========================================
Files 8 8
Lines 224 224
========================================
Hits 177 177
Misses 47 47 Continue to review full report at Codecov.
|
Ah interesting; can you walk me through what's going on here that's enabling Carthage support? Possibly in the PR description? Is it possible for us to add a test for this as well as part of Travis CI? |
Thank you for the description update! Is it correct that as part of our release process we'll also need to build and upload a fat .framework? |
Yes!
…On Wed, 13 Mar 2019 at 10:02, featherless ***@***.***> wrote:
Thank you for the description update! Is it correct that as part of our
release process we'll also need to build and upload a fat .framework?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADCPcRAUgIMJZd3NiBOeTmG1z5MExkuSks5vWFw1gaJpZM4bsLbD>
.
|
Not sure where the release script is but It'd look something like this: https://github.com/rynecheow/motion-interchange-objc/releases |
Alright I'll give it a go after this PR is merged! |
All green? |
Adding Carthage support by creating
MotionInterchange.framework
target with it's scheme share so that Carthage is able to find an build it's shared scheme according to what is defined in the scheme.By correctly exposing the public headers and hiding the private headers, this will also tell Xcode to build and include the correct headers available to library consumers.