Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Adding Carthage support #45

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Adding Carthage support #45

merged 1 commit into from
Mar 13, 2019

Conversation

rynecheow
Copy link
Contributor

@rynecheow rynecheow commented Mar 13, 2019

Adding Carthage support by creating MotionInterchange.framework target with it's scheme share so that Carthage is able to find an build it's shared scheme according to what is defined in the scheme.

By correctly exposing the public headers and hiding the private headers, this will also tell Xcode to build and include the correct headers available to library consumers.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@romoore romoore requested a review from jverkoey March 13, 2019 01:05
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #45 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #45   +/-   ##
========================================
  Coverage    79.01%   79.01%           
========================================
  Files            8        8           
  Lines          224      224           
========================================
  Hits           177      177           
  Misses          47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b27e6...8e6adca. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #45 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #45   +/-   ##
========================================
  Coverage    79.01%   79.01%           
========================================
  Files            8        8           
  Lines          224      224           
========================================
  Hits           177      177           
  Misses          47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b27e6...8e6adca. Read the comment docs.

@jverkoey
Copy link
Contributor

Ah interesting; can you walk me through what's going on here that's enabling Carthage support? Possibly in the PR description?

Is it possible for us to add a test for this as well as part of Travis CI?

@jverkoey
Copy link
Contributor

Thank you for the description update! Is it correct that as part of our release process we'll also need to build and upload a fat .framework?

@rynecheow
Copy link
Contributor Author

rynecheow commented Mar 13, 2019 via email

@rynecheow
Copy link
Contributor Author

rynecheow commented Mar 13, 2019

Not sure where the release script is but carthage build --archive --platform iOS --cache-builds will do the magic and build a MotionInterchange.framework.zip, and release on Github with this zip uploaded.

It'd look something like this: https://github.com/rynecheow/motion-interchange-objc/releases

@jverkoey
Copy link
Contributor

Alright I'll give it a go after this PR is merged!

@rynecheow
Copy link
Contributor Author

All green?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants