Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chip): Add density mixin to chip. #5109

Merged
merged 6 commits into from
Sep 19, 2019
Merged

feat(chip): Add density mixin to chip. #5109

merged 6 commits into from
Sep 19, 2019

Conversation

joyzhong
Copy link
Contributor

@joyzhong joyzhong commented Sep 19, 2019

Fixes #5100:

  • Adds density mixin to chip, with supported values 0 (default), -1, and -2
  • Adds screenshot test for chip with density mixin applied

@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #5109 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5109   +/-   ##
========================================
  Coverage    98.67%   98.67%           
========================================
  Files          122      122           
  Lines         6032     6032           
  Branches       796      796           
========================================
  Hits          5952     5952           
  Misses          79       79           
  Partials         1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4913db9...d739ecd. Read the comment docs.

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left few minor comments.

packages/mdc-chips/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-chips/_variables.scss Outdated Show resolved Hide resolved
packages/mdc-chips/_variables.scss Outdated Show resolved Hide resolved
packages/mdc-chips/_mixins.scss Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from develop on commit 71b545f:

Details

@joyzhong
Copy link
Contributor Author

Ready for review.

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from develop on commit d739ecd:

Details

@joyzhong joyzhong merged commit bdf3430 into develop Sep 19, 2019
@joyzhong joyzhong deleted the feat/density/chips branch September 19, 2019 19:06
@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants