Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select does't change value on option tag click (Firefox) #476

Closed
Rudellandy opened this issue Nov 28, 2018 · 3 comments
Closed

Select does't change value on option tag click (Firefox) #476

Rudellandy opened this issue Nov 28, 2018 · 3 comments
Assignees

Comments

@Rudellandy
Copy link

React: 16.6.0
@material/react-select: 0.7.0
Browser: Firefox 63.0.3 (64 bit)
OS: Ubuntu 18.04
userAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0

<Select> is not changing value on <option> click (event handler is getting old value). Value can be changed only using arrow keys. Exception occurs only on Firefox. On Chrome 70 and IE 11 works fine.

@moog16
Copy link

moog16 commented Nov 29, 2018

A few things are happening:

  • mousedown event does not bubble from child elements to parent element in Chrome. This does however, happen in Firefox. Firefox mousedown event is triggering NativeControl.setRippleCenter, which shouldn't be called when an is selected. Unanswered Questions: why does NativeControl.props.setRippleCenter() change the value emitted by onChange event. I'm thinking it might be a React bug We're going to review the PR fix and do a patch release when its ready. Thanks for filing this issue!

@moog16
Copy link

moog16 commented Nov 30, 2018

Released with v0.7.1! @Rudellandy

@Rudellandy
Copy link
Author

Great! Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants