Skip to content

[TabLayoutMediator] Don't try to detach an already detached TabLayout #4547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[TabLayoutMediator] Don't try to detach an already detached TabLayout #4547

wants to merge 1 commit into from

Conversation

pubiqq
Copy link
Contributor

@pubiqq pubiqq commented Jan 20, 2025

No description provided.

@pubiqq pubiqq mentioned this pull request Nov 11, 2024
Open
leticiarossi
leticiarossi approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@leticiarossi leticiarossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the warning is necessary, otherwise LGTM! I can remove the warning internally

@pubiqq
Copy link
Contributor Author

pubiqq commented May 9, 2025

It seems to me that if the attach() function throws an error when trying to attach an attached component, then the detach function should at least log an attempt to detach a detached component. Anyway, I'll leave it up to you.

@pekingme pekingme closed this in 6b35213 May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leticiarossi leticiarossi leticiarossi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pubiqq @leticiarossi