[Slider] Fixed behaviour when Slider is in a scrolling container #4511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfthomas
reviewed
Jan 6, 2025
| @@ -43,10 +44,11 @@ public View onCreateDemoView( | |||
| for (int i = 0; i < 50; i++) { | |||
| Slider slider = new Slider(layoutInflater.getContext()); | |||
| slider.setValueTo(11f); | |||
| slider.setOrientation(SliderOrientation.VERTICAL); | |||
There was a problem hiding this comment.
Could you create a separate demo for this?
There was a problem hiding this comment.
I created it.
| @@ -2864,17 +2865,24 @@ public boolean onTouchEvent(@NonNull MotionEvent event) { | |||
| } | |||
|
|
|||
| float eventCoordinate = isVertical() ? event.getY() : event.getX(); | |||
There was a problem hiding this comment.
Rename this to eventCoordinateX
There was a problem hiding this comment.
I renamed it.
| && abs(eventCoordinate - touchDownX) < scaledTouchSlop) { | ||
| return false; | ||
| } | ||
| // Check if we're trying to scroll horizontally instead of dragging this Slider | ||
| if (isVertical() && isPotentialHorizontalScroll(event) | ||
| && abs(eventCoordinateY - touchDownY) < scaledTouchSlop / 1.2) { |
There was a problem hiding this comment.
It is difficult for me to explain it...
If scaledTouchSlop is not divided by 1.2, it is difficult to slide (drag) vertical sliders. Try it.
There was a problem hiding this comment.
Is this also applicable for the vertical scroll or is it specific to this horizontal scroll?
There was a problem hiding this comment.
It seems to be specific to horizontal scroll. Don't you think so?
paulfthomas
added
the
Reviewing Internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4510