[MaterialDatePicker] Changed the header toggle to a MaterialButton #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikim24
reviewed
Oct 8, 2020
lib/java/com/google/android/material/datepicker/res/layout/mtrl_picker_header_toggle.xml
Outdated
Show resolved
Hide resolved
ikim24
suggested changes
Oct 8, 2020
lib/java/com/google/android/material/datepicker/res/layout/mtrl_picker_header_toggle.xml
Outdated
Show resolved
Hide resolved
|
Looks good to me. But we may need designer's approval for this. |
drchen
approved these changes
Jul 14, 2021
drchen
added
Awaiting Design Feedback
Reviewing Internally
|
Designer approved the change. : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the header toggle is an
ImageButtonwith a rounded ripple.With this PR the header toggle is a
MaterialButtonwith the same behavior of the cancel button on top in the header with a ripple based on the shape definition.It can be tested with the demo catalog.