Hide list panel from nav bar in mobile layout #19337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
reviewed
Oct 10, 2022
app/javascript/mastodon/features/ui/components/navigation_panel.js
Outdated
Show resolved
Hide resolved
ykzts
force-pushed
the
hide-list-panel
branch
from
e959290 to
6c999f8
Compare
ykzts
commented
Oct 10, 2022
| @@ -2755,7 +2759,7 @@ $ui-header-height: 55px; | |||
|
|
|||
| .column-actions { | |||
| display: flex; | |||
| align-items: start; | |||
| align-items: flex-start; | |||
There was a problem hiding this comment.
WARNING in ./app/javascript/styles/application.scss (./node_modules/css-loader/dist/cjs.js??ref--6-1!./node_modules/postcss-loader/src??ref--6-2!./node_modules/sass-loader/dist/cjs.js??ref--6-3!./app/javascript/styles/application.scss)
Module Warning (from ./node_modules/postcss-loader/src/index.js):
Warning
(5891:3) start value has mixed support, consider using flex-start instead
ykzts
force-pushed
the
hide-list-panel
branch
from
6c999f8 to
f35fc38
Compare
Gargron
approved these changes
Oct 10, 2022
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 19, 2022
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list panel is indistinguishable from the nav bar, which is lined with icons in the mobile UI. The list panel should be omitted from the nav bar since there is already a link that takes the user to the list page.