Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Use precompiled jemalloc, format, apply hadolint suggestions #10823

Merged
merged 3 commits into from
Mar 20, 2021
Merged

Docker: Use precompiled jemalloc, format, apply hadolint suggestions #10823

merged 3 commits into from
Mar 20, 2021

Conversation

SuperSandro2000
Copy link
Contributor

I noticed that 19.04 has precompilled jemalloc packages and I think this should be worth the upgrade. Of course it would need some testing if 19.04 breaks anything but those tests need to be done sooner than later anyway for people running on bare metal and Ubuntu 19.04.

@SuperSandro2000
Copy link
Contributor Author

SuperSandro2000 commented May 26, 2019 •
edited
Loading

This needs some more work as the compiled ruby did not pickup jemalloc.

Edit: Apparently the live image does not return jemalloc flags with ruby -r rbconfig -e "puts RbConfig::CONFIG['LIBS'] either.

Edit2: Apparently now you need to use ruby -r rbconfig -e "puts RbConfig::CONFIG['MAINLIBS']"

Edit3: Both the old and new now return the correct libs.

$ ruby -r rbconfig -e "puts RbConfig::CONFIG['MAINLIBS']"
-lz -lpthread -lrt -lrt -ljemalloc -ldl -lcrypt -lm

Edit4:
BTW if anyone is interested I keep all my PRs combined over here https://github.com/SuperSandro2000/mastodon/commits/all-docker

@shleeable
Copy link
Contributor

Don't commit atm.. ubuntu 19.04 should be fine, but 18.04 is still considered the stable/latest.

@SuperSandro2000
Copy link
Contributor Author

SuperSandro2000 commented Jun 5, 2019 •
edited
Loading

Latest is 19.04, lts is 18.04.
Bionic only has jemalloc 3 and downgrading two major version can't go well.

@stale
Copy link

stale bot commented Oct 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/wontfix This will not be worked on label Oct 26, 2019
@SuperSandro2000
Copy link
Contributor Author

I hate stale bot

@stale stale bot removed the status/wontfix This will not be worked on label Oct 26, 2019
@ykzts
Copy link
Member

ykzts commented Oct 26, 2019

@SuperSandro2000 Can you resolve conflicts?

@SuperSandro2000
Copy link
Contributor Author

I can do this later today.

@SuperSandro2000 SuperSandro2000 requested a review from ykzts October 27, 2019 11:34
@stale
Copy link

stale bot commented Feb 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/wontfix This will not be worked on label Feb 25, 2020
@SuperSandro2000
Copy link
Contributor Author

bump

@stale stale bot removed the status/wontfix This will not be worked on label Feb 25, 2020
@stale
Copy link

stale bot commented Jun 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/wontfix This will not be worked on label Jun 24, 2020
@shleeable
Copy link
Contributor

shleeable commented Jun 26, 2020 •
edited
Loading

@SuperSandro2000 feel free to update this for 20.04... and I'll test it out
otherwise, worth closing this PR

@stale stale bot removed the status/wontfix This will not be worked on label Jun 26, 2020
@SuperSandro2000 SuperSandro2000 changed the title Docker: Upgrade to Ubuntu 19.04, use precompiled jemalloc Docker: Use precompiled jemalloc, format, apply hadolint suggestions Jun 29, 2020
@SuperSandro2000
Copy link
Contributor Author

@shleeable Updated the PR.

@PureTryOut
Copy link

Seeing this has 2 approvals already, is there an ETA for merging this? It's kinda a blocker for getting Mastodon running on arm64 machines.

@ykzts
Copy link
Member

ykzts commented Jul 12, 2020

Re-run Circle CI workflow

@PureTryOut
Copy link

What is blocking this still?

@SuperSandro2000
Copy link
Contributor Author

What is blocking this still?

A merge conflict which I just solved.

@SuperSandro2000
Copy link
Contributor Author

Can this finally be merged? This reduces the complexity of the Dockerfile by a lot.

@jaredallard
Copy link

@SuperSandro2000 Could you fixed the conflicts? Hoping this gets merged... 🙏

@SuperSandro2000
Copy link
Contributor Author

@jaredallard yeah, probably not.

Base automatically changed from master to main January 20, 2021 10:31
@ClearlyClaire
Copy link
Contributor

Looks good to me, I don't know why the CI didn't run though. Could you rebase and force-push?

@SuperSandro2000
Copy link
Contributor Author

Looks good to me, I don't know why the CI didn't run though. Could you rebase and force-push?

Done. Lets see what happens.

@Gargron Gargron merged commit 46d3d31 into mastodon:main Mar 20, 2021
chrisguida pushed a commit to Start9Labs/mastodon that referenced this pull request Feb 26, 2022
@SuperSandro2000 @chrisguida
Docker: Use precompiled jemalloc, format, apply hadolint suggestions (m…
26a6d26 
…astodon#10823)

* Format, apply hadolint suggestions, little nitpicks

* Use pre compiled jemalloc

* Use tini from package repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

@Gargron Gargron Gargron approved these changes

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SuperSandro2000 @shleeable @ykzts @PureTryOut @jaredallard @ClearlyClaire @Gargron