Changed maven compile to be more strict with lint issues, and fixed a couple of issues along the way:

* [fallthrough] possible fall-through into case
* [this-escape] possible 'this' escape before subclass is fully initialized

Author: bramp

pom.xml

@@ -330,7 +330,12 @@
                     <compilerId>javac-with-errorprone</compilerId>
                     <forceJavacCompilerUse>true</forceJavacCompilerUse>
                     <showWarnings>true</showWarnings>
+                    <failOnError>true</failOnError>
+                    <failOnWarning>true</failOnWarning>
                     <compilerArgs>
+                        <!-- Surpress maven option warnings because we are
+                        focusing on code issues -->
+                        <arg>-Xlint:-options</arg>
                         <arg>-Xlint:all</arg>
                     </compilerArgs>
                 </configuration>

src/main/java/net/bramp/ffmpeg/FFmpeg.java

@@ -92,6 +92,7 @@ public FFmpeg(@Nonnull String path) throws IOException {
     this(path, new RunProcessFunction());
   }
 
+  @SuppressWarnings("this-escape")
   public FFmpeg(@Nonnull String path, @Nonnull ProcessFunction runFunction) throws IOException {
     super(path, runFunction);
     version();

src/main/java/net/bramp/ffmpeg/info/Codec.java

@@ -64,6 +64,7 @@ public Codec(String name, String longName, String flags) {
         break;
       case 'T':
         this.type = CodecType.ATTACHMENT;
+        break;
       default:
         throw new IllegalArgumentException("Invalid codec type '" + flags.charAt(2) + "'");
     }

src/main/java/net/bramp/ffmpeg/nut/Frame.java

@@ -1,6 +1,7 @@
 package net.bramp.ffmpeg.nut;
 
 import com.google.common.base.MoreObjects;
+import java.io.EOFException;
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.util.Map;
@@ -162,7 +163,12 @@ public void read(NutReader nut, NutDataInputStream in, int code) throws IOExcept
       long pos = in.offset();
       sideData = readMetaData(in);
       metaData = readMetaData(in);
-      size -= (in.offset() - pos);
+      long metadataLen = (in.offset() - pos);
+      if (metadataLen > size) {
+        throw new EOFException();
+      }
+
+      size -= (int) metadataLen;
 
     } else {
       sideData = null;