Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mdurant v3 fsspec #23

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Conversation

d-v-b
Copy link

@d-v-b d-v-b commented Jun 9, 2024

Adds an instance of StoreTests parametrized by RemoteStore, and refactors the store tests layout

Not mergeable until we figure out why the tests are failing

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

tests/v3/test_store/test_remote.py Outdated Show resolved Hide resolved
tests/v3/test_store/test_remote.py Outdated Show resolved Hide resolved
tests/v3/test_store/test_remote.py Outdated Show resolved Hide resolved
@d-v-b
Copy link
Author

d-v-b commented Jun 10, 2024

@martindurant can you approve the workflows so we can see some test failures? that's the part I need help with :)

@martindurant
Copy link
Owner

I see no test failures :)

@martindurant martindurant merged commit 7c22f74 into martindurant:v3_fsspec Jun 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants