Broken gh logger #671
Broken gh logger #671
Conversation
Update to preview 1 of .NET 9.
* Update .NET SDK Update .NET SDK to version 9.0.100-preview.2.24157.14. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 9.0.0-preview.1.24081.5 to 9.0.0-preview.2.24128.4 Bumps Microsoft.AspNetCore.Mvc.Testing from 9.0.0-preview.1.24081.5 to 9.0.0-preview.2.24128.4. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com>
* Update .NET SDK Update .NET SDK to version 9.0.100-preview.3.24204.13. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 9.0.0-preview.2.24128.4 to 9.0.0-preview.3.24172.13 Bumps Microsoft.AspNetCore.Mvc.Testing from 9.0.0-preview.2.24128.4 to 9.0.0-preview.3.24172.13. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com>
* Update .NET SDK Update .NET SDK to version 9.0.100-preview.4.24267.66. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 9.0.0-preview.3.24172.13 to 9.0.0-preview.4.24267.6 Bumps Microsoft.AspNetCore.Mvc.Testing from 9.0.0-preview.3.24172.13 to 9.0.0-preview.4.24267.6. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Fix build Add compatibility suppression for netstandard2.0. * Fix ambiguous methods Remove span to use params span overloads. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
CA1515 is now disabled in the ruleset file.
| with: | ||
| global-json-file: global.json |
There was a problem hiding this comment.
FYI you shouldn't need to do this - it'll automatically install the version specified in global.json already.
|
If you rebase onto the dotnet-vnext branch, the compiler errors should have already been sorted. |
|
https://github.com/nohwnd/terminal-logger-gh/actions/runs/9383838282?pr=1 it seems to work on mine with preview5, in fact the macos output is the nicest :D I think there was also a bug in sdk where macos tests crashed on xunit , this one dotnet/sdk#40194 so maybe we are hitting the crash here on macos. But the lack of output is preventing us from seeing it. I've made an issue on msbuild here to print all the info that reaches console, instead of just the well known messages (Well known to Terminal logger). dotnet/msbuild#10203 |
|
Interesting - that might overlap with this issue (a crash on macOS) I've been getting, which is kinda what lead me back to dotnet/sdk#41299 in the first place: dotnet/runtime#102313 |
|
Approving the workflow run here, looks like it's still repro'ing (and the lack of information has switched from macOS to Windows) |
|
To me it looks more like .net installation issue. In the windows output it lists the .net runtimes and it does not have the preview5. and it finds it in program files, not in your private installation that comes from setup-dotnet. Pushed more changes to add dotnet_root, just to see if that will take us one step further. 9.0.0-preview.4.24266.19 is the runtime that is linked to the official preview4 SDK, so it worked for you before when you used 9.0.100-preview.4.24267.66, because you installed that via setup-dotnet to private installation and there already was a respective runtime on the agent. (at least that is my educated guess why we see it fail now and not before)
|
|
after dotnet_root we can see result on windows, but not on macos / linux, disabling terminal logger, let's see what it wanted to print, thanks for your patience 😁 |
|
got it, when you set DOTNET_SYSTEM_CONSOLE_ALLOW_ANSI_COLOR_REDIRECTION: 1 (you do that in build.yaml), it will output |
3 participants
Trying for issue dotnet/sdk#41299