fix: resolve comments

Author: minh0306

packages/qdrant-loader-mcp-server/pyproject.toml

@@ -41,7 +41,7 @@ dependencies = [
     "click>=8.0.0",
     "tomli>=2.0.0",
     "networkx>=3.0.0",
-    "qdrant-loader-core[openai]==0.7.3",
+    "qdrant-loader-core==0.7.3",
 ]
 
 classifiers = [

packages/qdrant-loader-mcp-server/src/qdrant_loader_mcp_server/search/hybrid/components/builder.py

@@ -30,16 +30,8 @@ def _create_llm_provider_from_env(logger: Any | None = None) -> Any | None:
                     if isinstance(maybe_llm, dict) and maybe_llm:
                         # Make a shallow copy so we can safely overlay defaults/env
                         llm_cfg = dict(maybe_llm)
-        except Exception as cfg_err:
+        except Exception:
             # Non-fatal: fall through to env-only defaults
-            if logger is not None:
-                try:
-                    logger.debug(
-                        "Failed to load config file, using env-only mode",
-                        error=str(cfg_err),
-                    )
-                except Exception:
-                    pass
             llm_cfg = None
 
         # 2) If no file config present, construct from environment (legacy behavior)
@@ -120,23 +112,7 @@ def _resolve_placeholder(
             llm_cfg.setdefault("embeddings", {})
 
         llm_settings = LLMSettings.from_global_config({"llm": llm_cfg})
-        provider = create_provider(llm_settings)
-
-        # Log provider creation result for debugging
-        if logger is not None:
-            try:
-                provider_type = type(provider).__name__
-                logger.info(
-                    "LLM provider created",
-                    provider_type=provider_type,
-                    provider_name=llm_cfg.get("provider"),
-                    has_api_key=bool(llm_cfg.get("api_key")),
-                    base_url=llm_cfg.get("base_url"),
-                )
-            except Exception:
-                pass
-
-        return provider
+        return create_provider(llm_settings)
     except ImportError:
         # Attempt monorepo-relative import by adding sibling core package to sys.path
         try:

packages/qdrant-loader-mcp-server/tests/unit/test_logging.py

@@ -1,5 +1,6 @@
 """Tests for logging utilities."""
 
+import shutil
 import logging
 import os
 import tempfile
@@ -145,7 +146,6 @@ def test_logging_config_setup_with_env_variables():
     finally:
         # Close all logging handlers before cleanup (Windows compatibility)
         logging.shutdown()
-        import shutil
 
         try:
             shutil.rmtree(tmp_dir, ignore_errors=True)

packages/qdrant-loader/tests/unit/config/test_workspace_integration.py

@@ -174,9 +174,7 @@ def test_workspace_database_path_override(self, temp_workspace):
         expected_path = str(workspace_config.database_path)
         actual_path = settings.state_db_path
 
-        # Normalize paths for comparison (handles Windows short paths)
-        from pathlib import Path
-
+         # Normalize paths for comparison (handles Windows paths consistently)
         assert Path(actual_path).resolve() == Path(expected_path).resolve()
         assert actual_path.endswith("qdrant-loader.db")
         # Check using resolved paths to handle short vs long path names

packages/qdrant-loader/tests/unit/connectors/localfile/test_localfile_id_consistency.py

@@ -1,6 +1,7 @@
 """Test document ID consistency for LocalFile connector."""
 
 import os
+import sys
 import tempfile
 from pathlib import Path
 
@@ -141,7 +142,6 @@ async def test_document_url_format(self, localfile_config, temp_dir):
     @pytest.mark.asyncio
     async def test_document_id_consistency_with_symlinks(self, temp_dir):
         """Test that document IDs remain consistent when accessing files through symlinks."""
-        import sys
 
         # Create a symlink to the temp directory
         symlink_dir = Path(temp_dir).parent / "symlink_test"
@@ -152,10 +152,9 @@ async def test_document_id_consistency_with_symlinks(self, temp_dir):
             symlink_dir.symlink_to(temp_dir)
         except OSError as e:
             # Skip test on Windows if user doesn't have symlink privileges
-            if sys.platform == "win32" and "privilege" in str(e).lower():
+            if sys.platform == "win32" and getattr(e, "winerror", None) == 1314:
                 pytest.skip("Symlink creation requires admin privileges on Windows")
             raise
-
         try:
 
             # Create test files in the original directory

packages/qdrant-loader/tests/unit/core/file_conversion/test_file_conversion.py

@@ -4,7 +4,7 @@
 import tempfile
 from pathlib import Path
 from unittest.mock import Mock, patch
-
+import sys
 import pytest
 
 from qdrant_loader.core.file_conversion import (
@@ -376,7 +376,6 @@ def test_validate_file_not_found(self):
 
     def test_validate_file_not_readable(self):
         """Test file validation with unreadable file."""
-        import sys
 
         # Skip on Windows - chmod doesn't work the same way
         if sys.platform == "win32":

packages/qdrant-loader/tests/unit/core/file_conversion/test_file_converter.py

@@ -2,7 +2,7 @@
 Unit tests for the file converter.
 """
 
-import signal
+import signal, sys
 import tempfile
 from pathlib import Path
 from unittest.mock import MagicMock, patch
@@ -72,14 +72,12 @@ def test_timeout_handler_initialization(self):
         assert handler.file_path == "/path/to/file.pdf"
         assert handler.old_handler is None
 
+    @pytest.mark.skipif(
+        sys.platform == "win32",
+        reason="signal.alarm not available on Windows"
+    )
     def test_timeout_handler_context_manager(self):
         """Test timeout handler as context manager."""
-        import sys
-
-        # Skip on Windows - signal.alarm not available
-        if sys.platform == "win32":
-            pytest.skip("signal.alarm not available on Windows")
-
         with patch("signal.signal") as mock_signal, patch("signal.alarm") as mock_alarm:
             handler = TimeoutHandler(30, "/path/to/file.pdf")