From f2368a61ca8128dc49d3c5be94160373fa17c707 Mon Sep 17 00:00:00 2001 From: Mars Hall Date: Tue, 2 Oct 2018 09:49:23 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9A=20notices=20about=20CRA=202=20inco?= =?UTF-8?q?mpatibility?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index f016a1fe..254c5b36 100644 --- a/README.md +++ b/README.md @@ -63,7 +63,7 @@ Ensure [requirements](#user-content-requires) are met, then execute the followin ✏️ *Replace `$APP_NAME` with the name for your unique app.* ```bash -npx create-react-app $APP_NAME +npx create-react-app@1.5.x $APP_NAME cd $APP_NAME git init heroku create $APP_NAME --buildpack mars/create-react-app @@ -86,12 +86,13 @@ Usage ✏️ *Replace `$APP_NAME` with the name for your unique app.* ```bash -npx create-react-app $APP_NAME +npx create-react-app@1.5.x $APP_NAME cd $APP_NAME ``` * [npx](https://medium.com/@maybekatz/introducing-npx-an-npm-package-runner-55f7d4bd282b) comes with npm 5.2+ and higher, see [instructions for older npm versions](https://gist.github.com/gaearon/4064d3c23a77c74a3614c498a8bb1c5f) -* If [yarn](https://yarnpkg.com) is installed locally, the new app will use it instead of [npm](https://www.npmjs.com). +* if [yarn](https://yarnpkg.com) is installed locally, the new app will use it instead of [npm](https://www.npmjs.com) +* version 1.5.x is specified because [runtime env vars](#user-content-runtime-configuration) are not yet compatible with version 2.0.x ([issue #131](https://github.com/mars/create-react-app-buildpack/issues/131)) ### Make it a git repo @@ -384,6 +385,8 @@ REACT_APP_HEROKU_SLUG_COMMIT=$HEROKU_SLUG_COMMIT react-scripts build Supports only [`REACT_APP_`](https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#adding-custom-environment-variables) prefixed variables. +🚨 *Not yet compatible with **Create React App 2** ([issue #131](https://github.com/mars/create-react-app-buildpack/issues/131))* + 🚫🤐 ***Not for secrets.** These values may be accessed by anyone who can see the React app.* Install the [runtime env npm package](https://www.npmjs.com/package/@mars/heroku-js-runtime-env):