[TypeScript] Fix data provider packages export non-strict types #9970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Jul 2, 2024
| @@ -35,14 +35,17 @@ import { fetchUtils, DataProvider } from 'ra-core'; | |||
| */ | |||
| export default (apiUrl, httpClient = fetchUtils.fetchJson): DataProvider => ({ | |||
| getList: (resource, params) => { | |||
| const { page, perPage } = params.pagination; | |||
| const { field, order } = params.sort; | |||
| const { page, perPage } = params.pagination || {}; | |||
There was a problem hiding this comment.
We should have to do the same for getManyReference, except the Params types for the two methods don't match... params are optional in getList and required for getManyReference.
react-admin/packages/ra-core/src/types.ts
Lines 146 to 152 in 2182b5d
react-admin/packages/ra-core/src/types.ts
Lines 184 to 192 in 2182b5d
djhi
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since third-party data providers stem from ours, we should provide data providers that compile with strictNullChecks