Fix <SimpleList>
always returns empty when controlled
#9802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<SimpleList data={data}>
always renders an empty list regardless of the data.Test the ra-ui-material-ui/list/simplelist/basic story to see the bug.
Cause
Even when the
data
prop is set, this condition forces the rendering of the empty component becausetotal
is also undefined.react-admin/packages/ra-ui-materialui/src/list/SimpleList/SimpleList.tsx
Lines 123 to 129 in a402c38
The condition is different in
<Datagrid>
:react-admin/packages/ra-ui-materialui/src/list/datagrid/Datagrid.tsx
Lines 219 to 225 in a402c38
Solution
Remove the test on
total
in<SimpleList>
empty clause