Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add screencasts and screenshot to <EditableDatagrid> docs #9633

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

erwanMarmelab
Copy link
Contributor

Problem

There are too few illustrations on the EditableDatagrid doc page

Solution

Add illustrations

@fzaninotto
Copy link
Member

We actually don't need the webm versions - mp4 should work on all platforms. However, you need to test your mp4 with Safari, which doesn't accept all the codecs. Could you remove them and force push to avoid having them in the GH history?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this one, kudos!

@djhi djhi added this to the 4.16.10 milestone Feb 5, 2024
@djhi djhi merged commit 3dc0e49 into master Feb 5, 2024
5 checks passed
@djhi djhi deleted the feat/add-screenshots-to-EditableDatagrid-doc branch February 5, 2024 08:05
@slax57 slax57 changed the title [Doc] Add screencasts and screenshot to EditableDatagrid OSS doc [Doc] Add screencasts and screenshot to <EditableDatagrid> docs Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants