Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useReferenceManyFieldController does not debounce setFilters #9523

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Dec 13, 2023

Fixes #9517

Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably also need to update ReferenceManyField and its documentation


it('should take only last change in case of a burst of setFilters calls (case of inputs being currently edited)', async () => {
let childFunction = ({ setFilters, filterValues }) => (
// TODO: we shouldn't import mui components in ra-core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment should be removed

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good but I agree with @fzaninotto

@djhi
Copy link
Collaborator Author

djhi commented Dec 14, 2023

You probably also need to update ReferenceManyField and its documentation

I don't see anything to update

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better 😁

docs/ReferenceManyField.md Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit e5d562e into master Dec 15, 2023
2 checks passed
@fzaninotto fzaninotto deleted the reference-many-field-set-filters-debounce branch December 15, 2023 10:49
@fzaninotto fzaninotto added this to the 4.16.3 milestone Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceManyField ignores filter debounce
3 participants