-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix useReferenceManyFieldController
does not debounce setFilters
#9523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably also need to update ReferenceManyField
and its documentation
|
||
it('should take only last change in case of a burst of setFilters calls (case of inputs being currently edited)', async () => { | ||
let childFunction = ({ setFilters, filterValues }) => ( | ||
// TODO: we shouldn't import mui components in ra-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment should be removed
packages/ra-core/src/controller/field/useReferenceManyFieldController.spec.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems good but I agree with @fzaninotto
I don't see anything to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better 😁
Fixes #9517