RA-OSS-20 - Some Inputs with choices in their props do not accept ReadonlyArray<T> #9162
+11
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: passy4ucj <ojinnnakapascal@gmail.com> Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
Co-authored-by: passy4ucj <ojinnnakapascal@gmail.com> Co-authored-by: GitStart <1501599+gitstart@users.noreply.github.com> Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
Co-authored-by: Azerii <32432927+Azerii@users.noreply.github.com>
|
Thanks for this updated version. I must admit I'm a bit reluctant to accept this solution, because of all the An alternative solution, that would be cleaner IMO, would be to use generic types in this manner: interface ChoicesProps <T = any[]> {
choices?: T extends Array<any> ? T : T extends ReadonlyArray<any> ? T : "must be Array or ReadonlyArray";
}However this would also require propagating the type to inner layers of the code. So it may lead to many changed files... You can give it a try if you will, but I must remind that, for the reasons explained here, and because it is so easy to fix in user-land, we are not willing to invest too much time on resolving this issue in case it starts becoming too complex. |
Co-authored-by: Azerii <32432927+Azerii@users.noreply.github.com>
|
@slax57 we tried another fix can you check it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.