Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix add Roboto font integration step to vite tutorial #8419

Merged
merged 7 commits into from
Nov 22, 2022

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Nov 21, 2022

Related to #8407

@WiXSL WiXSL added the RFR Ready For Review label Nov 21, 2022
@smeng9
Copy link
Contributor

smeng9 commented Nov 22, 2022

I think we also need to update https://github.com/marmelab/react-admin/blob/master/docs/Vite.md for changes in both #8415 and #8419

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(very) minor change suggestion

docs/Tutorial.md Outdated Show resolved Hide resolved
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the code in the examples/tutorial directory, too!

docs/Tutorial.md Show resolved Hide resolved
@fzaninotto fzaninotto merged commit abd0082 into master Nov 22, 2022
@fzaninotto fzaninotto deleted the fix-vite-font branch November 22, 2022 13:45
@fzaninotto fzaninotto added this to the 4.5.3 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants