Make possible to use a SimpleList as a child of an ArrayField#6975
Merged
fzaninotto merged 2 commits intomasterfrom Dec 15, 2021
Merged
Make possible to use a SimpleList as a child of an ArrayField#6975fzaninotto merged 2 commits intomasterfrom
fzaninotto merged 2 commits intomasterfrom
Conversation
Luwangel
changed the title
WiXSL
approved these changes
Dec 10, 2021
djhi
suggested changes
Dec 14, 2021
Contributor
djhi
left a comment
djhi
left a comment
There was a problem hiding this comment.
Can you add a test for the ArrayField and SimpleList?
Member
|
Why don't you use useList? It's the perfect use case for it. https://github.com/marmelab/react-admin/blob/next/docs/useList.md |
Contributor
Author
The fix here is to make the ArrayField / SimpleList work together. But you're right, there are other ways to build this kind of feature. |
fzaninotto
approved these changes
Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
<ArrayField>builds a list context by passing null as total. TheSimpleListexpects a total > 0 to be rendered. Both are incompatible.I studied two solutions:
To not introduce breaking changes, and because it's cleaner, I choose the first solution.
Related Issue
Fixing #6974