Open
Conversation
hnykda
commented
Nov 24, 2019
Author
hnykda
left a comment
hnykda
left a comment
There was a problem hiding this comment.
The blocks which I commented out could potentially display some sensitive data, so I rather hid them.
| "* Go to the Developer Section of the Oura Cloud (https://cloud.ouraring.com/oauth/developer).\n", | ||
| "* Go to “My Applications” and create a new application by clicking on “New Application”.\n", | ||
| "* Fill out the form fields with your data.\n", | ||
| "* Fill out the form fields with your data. You need to check `Allow client-side authentication (grant-type token)`\n", |
Author
There was a problem hiding this comment.
Maybe only one of them is needed, not sure which one.
| # Save it for use later to prevent xsrf attacks | ||
| from uuid import uuid4 | ||
| state = str(uuid4()) | ||
| save_created_state(state) |
Author
There was a problem hiding this comment.
this one is simply not defined anywhere -> doesn't work
|
|
||
| def make_authorization_url(): | ||
| # Generate a random string for the state parameter | ||
| # Save it for use later to prevent xsrf attacks |
Author
There was a problem hiding this comment.
I think xsrf attacks for a thing which runs for a 30 seconds on localhost is pretty safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for the great work, here are some fixes for me to be able to run it today.