Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup window stuck in callback #2

Closed
pdrbrnd opened this issue Jun 20, 2018 · 3 comments
Closed

Popup window stuck in callback #2

pdrbrnd opened this issue Jun 20, 2018 · 3 comments

Comments

@pdrbrnd
Copy link

pdrbrnd commented Jun 20, 2018

Hi,

First of all, thanks for this.
We must be doing something wrong, so let me apologise beforehand for bothering you with this.

I see you have an Issue opened at netlify-cms's repo (decaporg/decap-cms#1285) with the exact same problem. I was wondering how did you managed to solve it?

Our auth popup window just hangs with the callback URL even tho our API Gateway endpoint is returning the correct response (with the correct postMessage 'authorization:github:success:{"token":TOKEN ...)

@marksteele
Copy link
Owner

I'm not sure where things are going wrong for you. The issue I had opened got fixed by allowing to set the auth_endpoint in the netlify config.

Blog post with my setup: https://www.control-alt-del.org/post/serverless-blog-howto

If you want to see the output of the blog (as generated from running hugo), it's here: https://github.com/marksteele/marksteele.github.io

(check out the /admin folder for the netflify config)

The repo for the source is here: https://github.com/marksteele/blog

It's running fine for me with version 1.9.2

The only difference I can think of between the blog post and my live setup is that I'm remapping urls in cloudfront, but that was just a style thing, I had it working as described in the blog before I had remapped them.

@ArcaneTSGK
Copy link

@pbrandone Did you manage to solve your issue with the popup window?

@pdrbrnd
Copy link
Author

pdrbrnd commented Aug 10, 2018

@ArcaneTSGK sorry for the delay. Apparently it was only a permissions issue with Github. Make sure you have granted the correct permissions when authorising the app. In my case I had previously auth'ed with my personal account and then things got a bit messed up on the Org's private repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants