added option to specify multiple teams in opsgenie configuration#2
Merged
Conversation
added 2 commits
August 25, 2021 11:27
Signed-off-by: Marko Posavec <maposavec@infobip.com>
Signed-off-by: Marko Posavec <maposavec@infobip.com>
markoposavec
force-pushed
the
dynamic-opsgenie-responders
branch
from
c84be58 to
e0f5e3c
Compare
markoposavec
pushed a commit
that referenced
this pull request
Nov 4, 2021
so third parties, Grafana in particular, can over ride the validation. Grafana wants to do this because other data sources will have label keys with things like spaces, periods, or other characters - and looking for a better integration with alert manager. goes with grafana/grafana#38629 replaces prometheus#2694 Signed-off-by: Kyle Brandt <kyle@grafana.com>
markoposavec
pushed a commit
that referenced
this pull request
Nov 4, 2021
so third parties, Grafana in particular, can over ride the validation. Grafana wants to do this because other data sources will have label keys with things like spaces, periods, or other characters - and looking for a better integration with alert manager. goes with grafana/grafana#38629 replaces prometheus#2694 Signed-off-by: Kyle Brandt <kyle@grafana.com>
markoposavec
pushed a commit
that referenced
this pull request
Nov 4, 2021
so third parties, Grafana in particular, can over ride the validation. Grafana wants to do this because other data sources will have label keys with things like spaces, periods, or other characters - and looking for a better integration with alert manager. goes with grafana/grafana#38629 replaces prometheus#2694 Signed-off-by: Kyle Brandt <kyle@grafana.com> Signed-off-by: Marko Posavec <Marko.Posavec@infobip.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I added an option to include multiple teams in alert as requested in this issue: prometheus#1987
My current solution adds a new type option for Opsgenie responders - "teams" that are safe split by comma and then changed back into a list of teams. Other option would be to split current teams by comma.
Any suggestions on how to approach this are welcome!
Thank you.