Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev webpack peer dependency? #8

Closed
cmloegcmluin opened this issue Feb 10, 2021 · 2 comments · Fixed by #9
Closed

rev webpack peer dependency? #8

cmloegcmluin opened this issue Feb 10, 2021 · 2 comments · Fixed by #9
Labels
enhancement New feature or request

Comments

@cmloegcmluin
Copy link

npm 7 no longer ignores peer dependency issues when installing. This package hasn't been updated in a while and still calls for webpack 4. We're up to webpack 5 now, but webpack still hasn't fixed the underlying issue. So I now have to remember to use --legacy-peer-deps every time. Perhaps, if there's no difference, you could update the package.json to use a peer dependency of Webpack 5 major version?

@markogresak
Copy link
Owner

@cmloegcmluin thanks for pointing this out, I will check it out. I'm also open to accepting a PR if you're willing to submit one 😄

@markogresak markogresak added the enhancement New feature or request label Feb 10, 2021
@markogresak
Copy link
Owner

@cmloegcmluin the problem is fixed with #9, published as patch v1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants