Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic tag with attribute tags and the ignoreUnrecognizedTags compiler option. #2298

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

DylanPiercey
Copy link
Contributor

Description

  • Fix issue with the "ignoreUnrecognizedTags" compiler option being used with dynamic tags that have attribute tags.
  • Removes the debug mode dom manipulation warning since chrome dropped the api's that allowed us to get useful stack traces.

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: e3257ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@marko/translator-default Patch
@marko/compiler Patch
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.65%. Comparing base (11dd01c) to head (e3257ae).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2298      +/-   ##
==========================================
- Coverage   88.66%   88.65%   -0.01%     
==========================================
  Files         340      340              
  Lines       35344    35338       -6     
  Branches     2060     2060              
==========================================
- Hits        31336    31329       -7     
- Misses       4008     4009       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit c01d83f into main Sep 23, 2024
9 checks passed
@DylanPiercey DylanPiercey deleted the fixes-09-23 branch September 23, 2024 16:26
@github-actions github-actions bot mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant