Can now specify a page length of 0 when searching with OkHttpServices.

Author: BillFarber

.gitignore

@@ -37,3 +37,4 @@ ml-development-tools/src/test/ml-modules
 ml-development-tools/src/test/java/com/marklogic/client/test/dbfunction/generated
 
 .vscode
+docker/

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestSearchPageLength.java

@@ -0,0 +1,73 @@
+/*
+ * Copyright © 2024 MarkLogic Corporation. All Rights Reserved.
+ */
+
+package com.marklogic.client.fastfunctest;
+
+import com.marklogic.client.impl.OkHttpServices;
+import com.marklogic.client.impl.RESTServices;
+import com.marklogic.client.io.*;
+import com.marklogic.client.query.*;
+import org.custommonkey.xmlunit.exceptions.XpathException;
+import org.junit.jupiter.api.*;
+import org.w3c.dom.Document;
+
+import static org.custommonkey.xmlunit.XMLAssert.*;
+
+
+class TestSearchPageLength extends AbstractFunctionalTest {
+
+	static final QueryManager queryMgr = client.newQueryManager();
+	StringQueryDefinition qd = queryMgr.newStringDefinition();
+
+	@Test
+	void testSearchPageLengthZero() throws XpathException {
+		queryMgr.setPageLength(0);
+		qd.setCriteria("Foo");
+		DOMHandle resultsHandle = new DOMHandle();
+		queryMgr.search(qd, resultsHandle);
+
+		Document resultDoc = resultsHandle.get();
+		assertXpathEvaluatesTo("0", "string(//*[local-name()='response']//@*[local-name()='page-length'])", resultDoc);
+	}
+
+
+	@Test
+	void testSearchPageLengthNegative() throws XpathException {
+		queryMgr.setPageLength(-1);
+		qd.setCriteria("Foo");
+		DOMHandle resultsHandle = new DOMHandle();
+		queryMgr.search(qd, resultsHandle);
+
+		Document resultDoc = resultsHandle.get();
+		assertXpathEvaluatesTo("10", "string(//*[local-name()='response']//@*[local-name()='page-length'])", resultDoc);
+	}
+
+	@Test
+	void testOkHttpPageLengthParamaterZero() throws XpathException {
+		RESTServices services = new OkHttpServices();
+		services.connect(client.getHost(), client.getPort(), null, DB_NAME, client.getSecurityContext());
+
+		qd.setCriteria("Foo");
+		DOMHandle resultsHandle = new DOMHandle();
+
+		int pageLength = 0;
+		services.search(client.newLogger(System.out), resultsHandle, qd, 1, pageLength, null, null, null);
+		Document resultDoc = resultsHandle.get();
+		assertXpathEvaluatesTo("0", "string(//*[local-name()='response']//@*[local-name()='page-length'])", resultDoc);
+	}
+
+	@Test
+	void testOkHttpPageLengthParamaterNegative() throws XpathException {
+		RESTServices services = new OkHttpServices();
+		services.connect(client.getHost(), client.getPort(), null, DB_NAME, client.getSecurityContext());
+
+		qd.setCriteria("Foo");
+		DOMHandle resultsHandle = new DOMHandle();
+
+		int pageLength = -1;
+		services.search(client.newLogger(System.out), resultsHandle, qd, 1, pageLength, null, null, null);
+		Document resultDoc = resultsHandle.get();
+		assertXpathEvaluatesTo("10", "string(//*[local-name()='response']//@*[local-name()='page-length'])", resultDoc);
+	}
+}

marklogic-client-api/src/main/java/com/marklogic/client/impl/OkHttpServices.java

@@ -1908,7 +1908,7 @@ public <T extends SearchReadHandle> T search(RequestLogger reqlog, T searchHandl
       params.add("start", Long.toString(start));
     }
 
-    if (len > 0) {
+    if (len > -1) {
       params.add("pageLength", Long.toString(len));
     }
 

test-app/docker-compose.yaml

@@ -0,0 +1,18 @@
+name: marklogic-javaclient-test-app
+
+services:
+
+  marklogic:
+    image: "progressofficial/marklogic-db:latest"
+    platform: linux/amd64
+    environment:
+      - MARKLOGIC_INIT=true
+      - MARKLOGIC_ADMIN_USERNAME=admin
+      - MARKLOGIC_ADMIN_PASSWORD=admin
+    volumes:
+      - ./docker/marklogic/logs:/var/opt/MarkLogic/Logs
+    ports:
+      - "8000-8002:8000-8002"
+      - "8012:8012"
+      - "8014:8014"
+      - "8020:8020"