Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the input / output type of inputs / outputs in subgraphs #170

Closed
michelderu opened this issue Apr 6, 2020 · 4 comments
Closed

Remove the input / output type of inputs / outputs in subgraphs #170

michelderu opened this issue Apr 6, 2020 · 4 comments
Assignees
@epoilvet
Labels
bug Something isn't working fixed-in-branch fixed-in-master
Milestone
1.0.1

Comments

@michelderu
Copy link

It seems the input/output types have no meaning in input/output blocks in subgraphs. Can we remove them?
@josvanroosmalen
Copy link
Collaborator

This is already fixed in master. I believe i have also merged this poc1 branch which our poc works on. Most likely the master will get the map range values support as well, so they they can revert back to master.

@josvanroosmalen
Copy link
Collaborator

@epoilvet can you check this is fixed in master?

@epoilvet
Copy link
Contributor

epoilvet commented Apr 6, 2020

this is fixed in dedicated branch. I can merge

@epoilvet epoilvet self-assigned this Apr 6, 2020
@sashamitrovich sashamitrovich added this to the 1.0.1 milestone Apr 6, 2020
@sashamitrovich sashamitrovich added fixed-in-branch bug Something isn't working labels Apr 6, 2020
@sashamitrovich
Copy link
Contributor

Fixed in maser with 15433be
@josvanroosmalen, can you restest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epoilvet epoilvet

Labels
bug Something isn't working fixed-in-branch fixed-in-master
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
4 participants
@epoilvet @josvanroosmalen @michelderu @sashamitrovich