Tests that reproduce the problems from SPARK-1188.

Author: darabos

graphx/src/test/scala/org/apache/spark/graphx/impl/EdgePartitionSuite.scala

@@ -34,8 +34,8 @@ class EdgePartitionSuite extends FunSuite {
       builder.add(e.srcId, e.dstId, e.attr)
     }
     val edgePartition = builder.toEdgePartition
-    assert(edgePartition.reverse.iterator.map(_.copy()).toList === reversedEdges)
-    assert(edgePartition.reverse.reverse.iterator.map(_.copy()).toList === edges)
+    assert(edgePartition.reverse.iterator.toList === reversedEdges)
+    assert(edgePartition.reverse.reverse.iterator.toList === edges)
   }
 
   test("map") {
@@ -45,7 +45,7 @@ class EdgePartitionSuite extends FunSuite {
       builder.add(e.srcId, e.dstId, e.attr)
     }
     val edgePartition = builder.toEdgePartition
-    assert(edgePartition.map(e => e.srcId + e.dstId).iterator.map(_.copy()).toList ===
+    assert(edgePartition.map(e => e.srcId + e.dstId).iterator.toList ===
       edges.map(e => e.copy(attr = e.srcId + e.dstId)))
   }
 
@@ -58,7 +58,7 @@ class EdgePartitionSuite extends FunSuite {
       builder.add(e.srcId, e.dstId, e.attr)
     }
     val edgePartition = builder.toEdgePartition
-    assert(edgePartition.groupEdges(_ + _).iterator.map(_.copy()).toList === groupedEdges)
+    assert(edgePartition.groupEdges(_ + _).iterator.toList === groupedEdges)
   }
 
   test("indexIterator") {
@@ -72,8 +72,8 @@ class EdgePartitionSuite extends FunSuite {
 
     val edgePartition = builder.toEdgePartition
     assert(edgePartition.iterator.map(_.copy()).toList === sortedEdges)
-    assert(edgePartition.indexIterator(_ == 0).map(_.copy()).toList === edgesFrom0)
-    assert(edgePartition.indexIterator(_ == 1).map(_.copy()).toList === edgesFrom1)
+    assert(edgePartition.indexIterator(_ == 0).toList === edgesFrom0)
+    assert(edgePartition.indexIterator(_ == 1).toList === edgesFrom1)
   }
 
   test("innerJoin") {
@@ -87,7 +87,7 @@ class EdgePartitionSuite extends FunSuite {
     val a = makeEdgePartition(aList)
     val b = makeEdgePartition(bList)
 
-    assert(a.innerJoin(b) { (src, dst, a, b) => a }.iterator.map(_.copy()).toList ===
+    assert(a.innerJoin(b) { (src, dst, a, b) => a }.iterator.toList ===
       List(Edge(0, 1, 0), Edge(1, 0, 0), Edge(5, 5, 0)))
   }
 }

graphx/src/test/scala/org/apache/spark/graphx/impl/EdgeTripletIteratorSuite.scala

@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.graphx.impl
+
+import scala.reflect.ClassTag
+import scala.util.Random
+
+import org.scalatest.FunSuite
+
+import org.apache.spark.graphx._
+
+class EdgeTripletIteratorSuite extends FunSuite {
+  test("iterator.toList") {
+    val builder = new EdgePartitionBuilder[Int]
+    builder.add(1, 2, 0)
+    builder.add(1, 3, 0)
+    builder.add(1, 4, 0)
+    val vidmap = new VertexIdToIndexMap
+    vidmap.add(1)
+    vidmap.add(2)
+    vidmap.add(3)
+    vidmap.add(4)
+    val vs = Array.fill(vidmap.capacity)(0)
+    val iter = new EdgeTripletIterator[Int, Int](vidmap, vs, builder.toEdgePartition)
+    val result = iter.toList.map(et => (et.srcId, et.dstId))
+    assert(result === Seq((1, 2), (1, 3), (1, 4)))
+  }
+}