Improved the startup validation

Author: markfinger

js_host/base_server.py

@@ -67,6 +67,8 @@ def __init__(self, config_file=None, source_root=None, path_to_node=None):
         if not os.path.exists(self.get_path_to_config_file()):
             raise ConfigError('Config file {} does not exist'.format(self.get_path_to_config_file()))
 
+        self.validate_status()
+
     def get_path_to_config_file(self):
         if os.path.isabs(self.config_file):
             return self.config_file
@@ -233,10 +235,6 @@ def validate_status(self):
             raise ConfigError('No port has been defined in {}'.format(config))
 
     def connect(self):
-        if not self.has_validated_status:
-            self.validate_status()
-            self.has_validated_status = True
-
         if not self.is_running():
             raise ConnectionError('Cannot connect to {}'.format(self.get_name()))
 

tests/test_base_server.py

@@ -64,9 +64,10 @@ def test_raises_an_error_if_a_config_file_does_not_exist(self):
         )
 
     def test_raises_an_error_if_a_config_file_does_not_export_an_object(self):
-        server = self.BaseServerSubclass(
+        self.assertRaises(
+            ConfigError,
+            self.BaseServerSubclass,
             path_to_node=settings.PATH_TO_NODE,
             source_root=settings.SOURCE_ROOT,
             config_file=empty_config_file,
-        )
-        self.assertRaises(ConfigError, server.validate_status)
+        )