From a6d92eca10133fefa2fb5f162cbe3eb6e9b7164f Mon Sep 17 00:00:00 2001 From: Rebecca Chen Date: Mon, 6 May 2019 22:05:17 -0400 Subject: [PATCH] Adjust indentation of TODOs in third_party/2/gflags.pyi. (#2964) Having TODOs at a different level of indentation than the surrounding lines trips up pytype. --- tests/pytype_blacklist.txt | 1 - third_party/2/gflags.pyi | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/pytype_blacklist.txt b/tests/pytype_blacklist.txt index dba9c60c6df6..7f9e7133174c 100644 --- a/tests/pytype_blacklist.txt +++ b/tests/pytype_blacklist.txt @@ -9,7 +9,6 @@ stdlib/3/typing.pyi # third_party stubs with constructs that pytype doesn't yet support: third_party/2/fb303/FacebookService.pyi -third_party/2/gflags.pyi third_party/2/scribe/scribe.pyi third_party/2/tornado/gen.pyi third_party/2/tornado/httpserver.pyi diff --git a/third_party/2/gflags.pyi b/third_party/2/gflags.pyi index 53f2a147193b..87edd4e4a0bb 100644 --- a/third_party/2/gflags.pyi +++ b/third_party/2/gflags.pyi @@ -34,7 +34,7 @@ class FlagValues: def UseGnuGetOpt(self, use_gnu_getopt: bool = ...) -> None: ... def is_gnu_getopt(self) -> bool: ... IsGnuGetOpt = is_gnu_getopt -# TODO dict type + # TODO dict type def FlagDict(self) -> dict: ... def flags_by_module_dict(self) -> Dict[str, List[Flag]]: ... FlagsByModuleDict = flags_by_module_dict @@ -83,7 +83,7 @@ class FlagValues: AppendFlagsIntoFile = append_flags_into_file def write_help_in_xml_format(self, outfile: IO[str] = ...) -> None: ... WriteHelpInXMLFormat = write_help_in_xml_format -# TODO validator: gflags_validators.Validator + # TODO validator: gflags_validators.Validator def AddValidator(self, validator: Any) -> None: ... FLAGS: FlagValues @@ -113,7 +113,7 @@ class Flag: class ArgumentParser(object): syntactic_help: str -# TODO what is this + # TODO what is this def parse(self, argument: Any) -> Any: ... Parser = parse def flag_type(self) -> str: ...